diff --git a/plan/phase-5-consolidator/ws-a-config.md b/plan/phase-5-consolidator/ws-a-config.md index f4083b2..6f2f964 100644 --- a/plan/phase-5-consolidator/ws-a-config.md +++ b/plan/phase-5-consolidator/ws-a-config.md @@ -90,5 +90,6 @@ Unit tests for validation and loader; a peer-less default config is byte-identic - **Minor 6 (IPv4-mapped literals) — fixed here, not deferred.** `host_ip` canonicalises with `IpAddr::to_canonical`, so `http://[::ffff:169.254.169.254]` is matched against the IPv4 deny list (test `ipv4_mapped_ipv6_literals_match_the_v4_deny_list`); the same canonicalisation makes `[::ffff:127.0.0.1]` count as loopback. Connect-time enforcement stays B5's. - **Minor 7 (blocking loader) — recorded in WS-B's Log.** `load_token` is unchanged: it is called once at startup and once per API check by B's transport, inside its request deadline. B's transport already reads the file per check; the note asks for `spawn_blocking` or a bounded `tokio::fs` read if that ever moves to a hot path. - **Minor 8 (host in the plain-http error) — fixed.** The error no longer names the host, matching the warning that deliberately omits the address. + - **`src/main.rs` beyond the `Command::Peer` region (one line, as the review asked):** `serve()` now calls `config.validate_token_readiness()` before it installs the SIGHUP handler, opens the database or binds. `serve()` is otherwise WS-B's; the call is the whole of this workstream's change there, and it needs no cooperation from the registry. - **One edit outside the owned list, on purpose:** `src/peers/registry.rs` (B's file) had two fixtures with `api_interval_secs = 2` and the default `api_timeout_secs = 5`, which the A2 timeout rule rejects; the reload and SIGHUP tests failed as soon as the branches met. One line, `api_timeout_secs = 1`, added to the reload test's inline TOML; the other test's reload now passes because `Config::load` no longer opens token files. - **Scope note (for the merger):** wiring `real_transport` in this workstream is the plan's "A4 is wired when B1/B2 land" condition, taken now because B is merged and `cli.rs` is A's file. The seam paragraph in B's Log is updated to point here.