A0: review round 1 peer entry defaults and class strings

This commit is contained in:
ari committed 2026-10-19 20:02:17 -04:00
1 parent 4bfb097be6
commit 0dbaf58c8c
10 files changed
+276 -32

No files matched your search

+133 -9
View File
@@ -1,12 +1,15 @@
//! Peer seams exercised end to end against the fake transport and fake
//! sources: the peer-less default, the ping route, and registry reads.
use std::net::{IpAddr, Ipv4Addr};
use std::path::{Path, PathBuf};
use std::time::Duration;
use axum::body::{to_bytes, Body};
use axum::http::{Request, StatusCode};
use figment::Jail;
use skyg_linux_tracker::api;
use skyg_linux_tracker::config::Config;
use skyg_linux_tracker::config::{CliOverrides, Config};
use skyg_linux_tracker::peers::testing::{
fake_peers_config, fake_state_with_peers, registry_with, static_registry, FakeTransport,
};
@@ -51,16 +54,137 @@ async fn peerless_default_is_off_and_unchanged() {
assert!(!b.is_empty());
}
#[test]
#[allow(clippy::result_large_err)] // figment::Jail closures return figment::Error
fn vm_peer_entries_load_when_enabled_and_ca_file_are_omitted() {
Jail::expect_with(|jail| {
jail.create_file(
"peers.toml",
r#"
[server]
bind = "0.0.0.0"
[peers]
enabled = true
tcp_interval_secs = 2
tcp_timeout_secs = 1
api_interval_secs = 3
api_timeout_secs = 2
fail_threshold = 2
request_timeout_secs = 4
[[peers.peer]]
name = "beta"
url = "http://beta:1984"
token_file = "/run/credentials/skyg-linux-tracker.service/peer-beta"
allow_plain_http = true
[[peers.peer]]
name = "gamma"
url = "https://gamma:1984"
token_file = "/run/credentials/skyg-linux-tracker.service/peer-gamma"
ca_file = "/etc/ssl/private-ca.pem"
allow_plain_http = false
[[peers.peer]]
name = "delta"
url = "https://delta:1984"
token_file = "/run/credentials/skyg-linux-tracker.service/peer-delta"
enabled = false
"#,
)?;
let cfg = Config::load(Some(Path::new("peers.toml")), &CliOverrides::default())
.expect("peer entries must deserialize");
assert!(cfg.auth.enabled);
assert_eq!(cfg.server.bind, IpAddr::V4(Ipv4Addr::UNSPECIFIED));
assert!(cfg.peers.enabled);
assert_eq!(cfg.peers.tcp_interval_secs, 2);
assert_eq!(cfg.peers.api_timeout_secs, 2);
assert_eq!(cfg.peers.request_timeout_secs, 4);
assert_eq!(cfg.peers.max_response_bytes, 8 * 1024 * 1024);
let peer = |name: &str| {
cfg.peers
.peer
.iter()
.find(|p| p.name.as_str() == name)
.unwrap()
};
let beta = peer("beta");
assert!(beta.enabled);
assert!(beta.allow_plain_http);
assert!(beta.ca_file.is_none());
assert_eq!(
beta.token_file,
PathBuf::from("/run/credentials/skyg-linux-tracker.service/peer-beta")
);
let gamma = peer("gamma");
assert!(gamma.enabled);
assert!(!gamma.allow_plain_http);
assert_eq!(
gamma.ca_file.as_deref(),
Some(Path::new("/etc/ssl/private-ca.pem"))
);
let delta = peer("delta");
assert!(!delta.enabled);
assert!(!delta.allow_plain_http);
assert!(delta.ca_file.is_none());
Ok(())
});
}
#[tokio::test]
async fn ping_route_is_present_without_peers() {
let app = api::router(skyg_linux_tracker::sources::fake::fake_state(
Config::default(),
));
let (s, b) = get(&app, "/ping").await;
assert_eq!(s, StatusCode::OK);
let v: serde_json::Value = serde_json::from_str(&b).unwrap();
async fn ping_without_a_token_is_unauthorized() {
let pool = sqlx::sqlite::SqlitePoolOptions::new()
.max_connections(1)
.connect("sqlite::memory:")
.await
.unwrap();
skyg_linux_tracker::db::migrate(&pool).await.unwrap();
let token = skyg_linux_tracker::auth::tokens::create(&pool, "ping")
.await
.unwrap();
let mut config = Config::default();
config.auth.enabled = true;
let mut state = skyg_linux_tracker::sources::fake::fake_state(config);
state.db = Some(pool);
let app = skyg_linux_tracker::server::build_router(state);
let (status, body, www) = request(&app, "/api/v1/ping", None).await;
assert_eq!(status, StatusCode::UNAUTHORIZED);
assert_eq!(www.as_deref(), Some("Bearer"));
assert!(body.contains("unauthorized"));
let (status, body, _) = request(&app, "/api/v1/ping", Some(&format!("Bearer {token}"))).await;
assert_eq!(status, StatusCode::OK);
let v: serde_json::Value = serde_json::from_str(&body).unwrap();
assert_eq!(v["status"], "ok");
assert!(v["version"].is_string());
assert!(v["version"].as_str().is_some_and(|s| !s.is_empty()));
}
async fn request(
app: &axum::Router,
uri: &str,
authorization: Option<&str>,
) -> (StatusCode, String, Option<String>) {
let mut builder = Request::builder().uri(uri);
if let Some(auth) = authorization {
builder = builder.header("authorization", auth);
}
let resp = app
.clone()
.oneshot(builder.body(Body::empty()).unwrap())
.await
.unwrap();
let status = resp.status();
let www = resp
.headers()
.get(axum::http::header::WWW_AUTHENTICATE)
.and_then(|v| v.to_str().ok())
.map(str::to_owned);
let body = to_bytes(resp.into_body(), usize::MAX).await.unwrap();
(status, String::from_utf8(body.to_vec()).unwrap(), www)
}
#[tokio::test]