From 2769c6f999548f8dc04c57c5c0302e6c6f9733a4 Mon Sep 17 00:00:00 2001 From: ari Date: Tue, 20 Oct 2026 11:12:46 -0400 Subject: [PATCH] F: record review round 3 in the workstream log Log entry for the round and the hook-check port noted in the dated Handoff, so the orchestrator knows why four files outside the F list changed and what is left for the fold. --- plan/phase-5-consolidator/ws-f-nixos-docs.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plan/phase-5-consolidator/ws-f-nixos-docs.md b/plan/phase-5-consolidator/ws-f-nixos-docs.md index 24b9569..022d30a 100644 --- a/plan/phase-5-consolidator/ws-f-nixos-docs.md +++ b/plan/phase-5-consolidator/ws-f-nixos-docs.md @@ -88,6 +88,7 @@ Shippable, documented, verified. - `config.example.toml`: commentary only — one token per consolidator, the module's `tokenFile` option and a pointer to `docs/consolidator.md`. Keys and defaults unchanged and checked against `docs/consolidator.md` and `PeersConfig::default`. - Corrected F1's `caFile` description in `nix/module.nix`: nothing opens the CA at startup, so "fails at startup" was wrong; a root-only file makes every check and proxied request to that peer fail as `tls_error`. - Not an Owned file, so left for the fold: `docs/README.md`'s Reference table does not list `docs/consolidator.md` yet. +- 2026-10-20: **Review round 3** (`loop/F/review-n6.md`, findings 1 to 8) addressed, one commit per finding; the dated Handoff is at the end of this file. The two VM-test findings were product bugs and are fixed here: the proxy forwards `/api/v1/` (both formerly ignored tests are the acceptance check and pass) and the transport now uses every resolved address (`resolve_to_addrs`, `tcp_check` tries each, `ClientKey` keys on the set). `flake.nix` imports `nix/checks.nix` again, so the hook checks are back; because this branch predates main's `8c0f996`, the four files that commit fixed (`.markdownlint.yaml`, `dev/hooks/run.sh`, `nix/checks.nix`, the D8 table cell in `decisions.md`) were ported so the restored checks pass. `dev-test vm peers` builds `checks..vm-peers`, with a self-check guarding the attribute. Test and docs findings 5 to 8 done. Local gate: fmt, clippy, `cargo test` on every target and `nu dev/dev-test.nu self-check` green; no nix build run. ## Handoff 2026-10-20 (WS-F -> orchestrator) @@ -116,7 +117,8 @@ Shippable, documented, verified. - *Only the first resolved address was tried.* `resolve_target` returns every address and still refuses the name if **any** is denied; `ReqwestTransport` pins the set with `resolve_to_addrs` (the connector falls through), `ClientKey` keys on the set and `tcp_check` tries each address with a per-attempt share of the remaining deadline. Cover: two client unit tests, a `tests/peers.rs` case declaring the peer as `http://localhost:` against a peer bound to `127.0.0.1`, and the VM test's TLS peer `gamma` now binds `0.0.0.0` (IPv4 only) while `alpha`/`beta` stay dual stack. `docs/consolidator.md` (Address families, `deny_cidrs`) and contracts section 10 are rewritten; the "reported as unreachable" limitation is gone. **Findings 1, 4 to 8.** -- `flake.nix` imports `nix/checks.nix` again, merged with the F2 additions (`package`, `vm`, `vm-peers`, `module-peers`), so `hooks-lint`, `hooks-selection`, `rust-fmt`, `rust-clippy` and `rust-no-openssl` are back in `nix flake check`. `bash dev/hooks/run.sh lint-all` passes locally. +- `flake.nix` imports `nix/checks.nix` again, merged with the F2 additions (`package`, `vm`, `vm-peers`, `module-peers`), so `hooks-lint`, `hooks-selection`, `rust-fmt`, `rust-clippy` and `rust-no-openssl` are back in `nix flake check`. `bash dev/hooks/run.sh lint-all` and `dev/hooks/test-select.sh` pass locally. + - Because this branch predates main's `8c0f996` ("Fix hook flake checks, relax markdownlint style rules"), the restored `hooks-lint` would fail on files main already fixed. That commit's four functional files were ported verbatim, no rebase: `.markdownlint.yaml` (MD012/MD026/MD040/MD049 off), `dev/hooks/run.sh` (`return "$bad"` plus the shellcheck disable), `nix/checks.nix` (`found=` as on main) and the unescaped `|` in `decisions.md` D8. The two doc-pointer additions from that commit (AGENTS.md, README.md hooks.md links) were left out as unrelated to the finding; the orchestrator may want them with the fold. - `dev/dev-test.nu`: `vm peers` builds `.#checks..vm-peers`; a new `check-vm-attribute` self-check fails if a vm name stops pointing at `.#checks`. `nu dev/dev-test.nu self-check` prints ok. - Shutdown and slow loris: the test listener distinguishes a complete reply, headers plus a held socket, and headers plus one body byte per 300 ms. Shutdown now ends a held stream (no real peer involved), a slow-loris peer is a `503 timeout` inside 4 s, and the silent-peer bound dropped from 10 s to 4 s. - Redirect test waits for the health loop's `http_302` verdict before asserting the `Location` target saw zero connections; the peer cap asserts "at most 64 peers"; a chunked oversize body is refused end to end.