From db345fb0f8ffcda2de021c90cafa490504ba9d57 Mon Sep 17 00:00:00 2001 From: ari Date: Mon, 19 Oct 2026 23:10:15 -0400 Subject: [PATCH] D: fix test names in the round-1 log --- plan/phase-5-consolidator/ws-d-mcp.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plan/phase-5-consolidator/ws-d-mcp.md b/plan/phase-5-consolidator/ws-d-mcp.md index 1a2691c..be85d24 100644 --- a/plan/phase-5-consolidator/ws-d-mcp.md +++ b/plan/phase-5-consolidator/ws-d-mcp.md @@ -102,9 +102,9 @@ Both snapshot variants pass; each tool with `peer` returns the peer's data via t - **Blocking 2 (status table).** `status_error`, `body_bytes` and the local 2xx check are deleted; all peer responses now go through `proxy::prepare_response` / `proxy::classify_status`. **Contract note for the plan owner:** contracts section 4 and decision D9 still say peer 400/422 -> `BadRequest`, while C2's `classify_status` (the single table REST and MCP now share) maps 400 to `Http(400)` -> `503 peer

: http_400`. D has followed the review's instruction to reuse the table rather than keep a second one, so the contract row is now the thing that disagrees; settling it means either restoring 400/422 in `proxy.rs` (WS-C file) or updating section 4 and D9. - **Major 3 (entry cap).** `out.truncate(entry_cap)` before `capped(...)`, for the stream and the buffered-body branch, so the peer tool cannot return more than `limits.max_lines` entries. - **Major 4 (tests).** New unit tests: `peer_tail_journal_is_bounded_by_the_peer_byte_cap` (100 chunks of 512 bytes, no terminator, 4096-byte peer cap: returns at once, no entries, cap note), `peer_tail_journal_caps_entries_like_the_local_tool`, `peer_tail_journal_accepts_a_buffered_body`, `peer_tail_journal_maps_a_follow_error_like_rest` (404 and 500), `peer_tail_journal_ends_at_the_deadline_with_an_open_stream` (a transport whose stream never ends, paused clock) and `peer_tail_journal_stops_on_shutdown`; plus `Frames` cursor/terminator tests. New integration test `rest_and_mcp_report_the_same_peer_status_errors` compares the REST body (`code`, `message`, HTTP status, `x-slinuxm-peer`) with the MCP tool error for peer 400/404/401/500. - - **Minor 5 (golden).** `tool_list_without_peers_is_byte_identical` pins the full serialized `Tool` JSON of the peers-off table (not just property sets), so a reworded description or field doc comment fails the test. + - **Minor 5 (golden).** `tool_list_without_peers_matches_the_pre_peers_build` pins the full serialized `Tool` JSON of the peers-off table (not just property sets), so a reworded description or field doc comment fails the test. - **Minor 6 (literal list).** The integration snapshot uses a literal list of the ten names; the test-only `mcp::peers::tool_names()` helper is gone. - - **Minor 7 (one wording).** `peers::registry` keeps its doc honest ("no peers are configured"); the per-name 404 comes from `UnknownPeer`-style wording in `fetch` (only reachable with the feature off, where there is no registry) and from `PeerRegistry` itself otherwise; `list_peers` returns the error `registry()` produced instead of rebuilding the message. + - **Minor 7 (one wording).** `peers::registry` keeps its doc honest ("no peers are configured"); the per-name 404 comes from the `unknown_peer` wording in `fetch` (only reachable with the feature off, where there is no registry) and from `PeerRegistry` itself otherwise; `list_peers` returns the error `registry()` produced instead of rebuilding the message. - **Minor 8 (prompt peer).** `prompts::get` takes `Option<&PeerRegistry>` instead of a bool and resolves the `peer` argument against it: an unknown name is `not_found: peer : unknown peer`, a name whose entry is disabled is `peer : disabled`. The prompt can no longer send an agent at a peer whose tool calls would fail. **Verification (round 1 fixes):** `loop/gate.sh D main` -> GATE PASS (fmt, clippy, all lib + `tests/mcp_peers.rs` tests green, no openssl, ownership, duplication). `TODO.md` is not an owned file for D, so the D1/D2/D3 boxes are left for the merger to tick.