H: assert the exported peer request span kind
Export the span through a capturing exporter and require SpanKind::Client, so the contract is checked where a backend sees it, not only in the field that carries it.
This commit is contained in:
1 parent
5f9f160666
commit
5571b1d3a4
1 file changed
+47
@@ -584,6 +584,53 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
/// Collects finished spans, so a test can assert what a backend receives.
|
||||
#[derive(Debug, Clone, Default)]
|
||||
struct Exported(std::sync::Arc<std::sync::Mutex<Vec<opentelemetry_sdk::trace::SpanData>>>);
|
||||
|
||||
impl opentelemetry_sdk::trace::SpanExporter for Exported {
|
||||
async fn export(
|
||||
&self,
|
||||
batch: Vec<opentelemetry_sdk::trace::SpanData>,
|
||||
) -> opentelemetry_sdk::error::OTelSdkResult {
|
||||
self.0.lock().unwrap().extend(batch);
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn peer_request_span_is_exported_as_a_client_span() {
|
||||
use opentelemetry::trace::{SpanKind, TracerProvider as _};
|
||||
|
||||
let exported = Exported::default();
|
||||
let provider = SdkTracerProvider::builder()
|
||||
.with_span_processor(opentelemetry_sdk::trace::SimpleSpanProcessor::new(
|
||||
exported.clone(),
|
||||
))
|
||||
.build();
|
||||
let subscriber = tracing_subscriber::registry()
|
||||
.with(tracing_opentelemetry::layer().with_tracer(provider.tracer("test")));
|
||||
tracing::subscriber::with_default(subscriber, || {
|
||||
let span = peer_request_span("beta");
|
||||
span.in_scope(|| {});
|
||||
drop(span);
|
||||
});
|
||||
|
||||
let spans = exported.0.lock().unwrap();
|
||||
assert_eq!(spans.len(), 1, "one exported span");
|
||||
assert_eq!(spans[0].name, "peer.request");
|
||||
assert_eq!(spans[0].span_kind, SpanKind::Client);
|
||||
// `otel.kind` is consumed by the layer, never exported as an attribute.
|
||||
assert!(
|
||||
spans[0]
|
||||
.attributes
|
||||
.iter()
|
||||
.all(|kv| kv.key.as_str() != "otel.kind"),
|
||||
"{:?}",
|
||||
spans[0].attributes
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn peer_request_span_names_the_peer() {
|
||||
let recorded = Recorded::default();
|
||||
|
||||
Reference in new issue
Block a user