Commit Graph
205 Commits
Author SHA1 Message Date
ari 3ae8e74a1d F: forward the peer's /api/v1 path and un-ignore the proxied tests
The proxy validated the route without its API prefix and handed the
transport "/systemd/units", which a peer answered with 404. Validation
still works on the bare route; the transport now gets
"/api/v1/systemd/units". Un-ignoring the two acceptance tests
(a_plain_peer_serves_its_own_data_through_the_proxy and
shutdown_ends_a_proxied_follow) is the check for that fix; the unit
tests in api/, mcp/ and the registry script their fakes on the peer's
real paths again.
2026-10-20 15:04:09 -04:00
ari 2455486205 F: handoff for F2 to F4
Status, the nix commands to run, the blocking proxy defect reported to WS-C,
and the dev-test/doc seams.
2026-10-20 15:04:09 -04:00
ari 4d83c2eff5 F: F4 peers docs, agenix example and tool-count note
README peers section, docs/consolidator.md (threat model, tokens, firewall,
worked agenix example, reload/restart), the MCP tool count in both tables,
and config.example.toml commentary.
2026-10-20 15:04:09 -04:00
ari 66ee41a672 F: F3 end-to-end peer tests
Real registry and transport against in-process peers and hand-written
listeners: plain, TLS with an rcgen CA, a wrong CA, redirects, oversize
bodies, a silent peer, the 64-peer cap and shutdown mid-follow. Two proxy
cases are ignored: the proxied path is missing its /api/v1 prefix.
2026-10-20 15:04:09 -04:00
ari ca000d973f F: F2 promote the peers VM test and the module eval test into checks
The test nodes declare peers through the first-class module options, so
LoadCredential and RefreshOnReload come from the module. Every node binds
:: because the test network resolves node names to IPv6 first. poll()
raises with the last observed status JSON.
2026-10-20 15:04:09 -04:00
ari 4f5fa589ac F: F1 record review round 1 in the workstream log 2026-10-20 15:04:09 -04:00
ari d056f9df3a F: F1 eval cases for the restart/reload split and the new assertions 2026-10-20 15:04:09 -04:00
ari 7128321692 F: F1 restart on what SIGHUP cannot apply and settle the peers precedence
The config file now always stays a reload trigger, and the restart trigger
is the settings reduced to the keys the service cannot apply on SIGHUP, so
a peer edit reloads while a port, auth or limit change still restarts. The
first-class peers options win over the freeform bags, and the assertions
cover enabled peers, the 64-peer cap and LoadCredential-safe token paths.
2026-10-20 15:04:09 -04:00
ari 95e3533e83 F: F1 record module options, tests and handoff in the workstream log 2026-10-20 15:04:09 -04:00
ari e6cb4c0b3e F: F1 NixOS peers options with LoadCredential token delivery 2026-10-20 15:04:09 -04:00
ariandClaude Sonnet 5.5 38f1bf99fc Plan WS-G: generated OpenAPI doc
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dpKwZWtahQU4V2NhpVmLt
2026-10-20 10:22:34 -04:00
ariandClaude Sonnet 5.5 8c0f996262 Fix hook flake checks, relax markdownlint style rules, add hook pointers
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dpKwZWtahQU4V2NhpVmLt
2026-10-20 10:21:52 -04:00
ariandClaude Sonnet 5.5 9e4fb38993 Document hooks; drop review tag from a comment
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dpKwZWtahQU4V2NhpVmLt
2026-10-20 10:19:46 -04:00
ariandClaude Sonnet 5.5 0bddfbb063 Wire hooks into devenv and flake checks
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dpKwZWtahQU4V2NhpVmLt
2026-10-20 10:19:46 -04:00
ariandClaude Sonnet 5.5 46c644ff2b Add hook path mapping, runner and fixture tests
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dpKwZWtahQU4V2NhpVmLt
2026-10-20 10:19:46 -04:00
ariandClaude Sonnet 5.5 3798e330af D: mark merged
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 23:14:04 -04:00
ari db345fb0f8 D: fix test names in the round-1 log 2026-10-19 23:10:15 -04:00
ari c0e76607f6 D: reuse the shared proxy bounds and status table in MCP peers
The peer follow stream had no byte cap and kept a whole unterminated
frame in memory, and the MCP surface carried its own peer status table
that already disagreed with REST for peer 400.

- mcp::peers::fetch now returns proxy::PreparedResponse, so the status
  comes from proxy::classify_status and the body from
  proxy::prepare_response (peer byte cap, deadline, shutdown), the same
  two steps REST uses. status_error, body_bytes and the local 2xx check
  are gone.
- tail_journal consumes that prepared stream; a Frames cursor keeps a
  partial frame from being rescanned from byte 0 on every chunk, the
  entry cap truncates the result, and the end of the stream maps to the
  note (entry cap, shutdown, byte cap, deadline or close).
- Prompts resolve the peer argument against the registry (unknown or
  disabled peer is refused); list_peers returns the error registry()
  produced; one wording for an unknown peer name.
- Tests: byte cap on an unterminated frame, entry cap, buffered body,
  follow 404/500, deadline with an open stream, shutdown, frame cursor,
  REST/MCP parity for peer 400/404/401/5xx, and a full golden snapshot of
  the peers-off tool table. Peer scripts use the stripped path form C2
  forwards.
2026-10-19 23:09:45 -04:00
ari e2c553dbe4 D: share tool-name fixture and dedupe MCP peer tests 2026-10-19 22:59:49 -04:00
ari d1bec4a3d8 D: handoff for D1-D3 2026-10-19 22:59:49 -04:00
ari 5237e772d4 D: D3 peer wording, peers://status and peer-aware prompts
Server instructions and the eight tool descriptions mention peers and the
untrusted-data rule only while a registry is configured. peers://status
returns the list_peers JSON and is advertised only then. diagnose_unit and
container_health_report take an optional validated peer argument.
2026-10-19 22:59:49 -04:00
ari ae09f0530c D: D2 list_peers and get_peer behind peers.enabled
The two status tools and the optional peer argument exist only when a
registry is configured. rmcp's disable_route hides the tools; the eight
shared schemas lose the optional peer property, and the two list tools also
lose the derived $schema key, so the peers-off list and schemas match a
build without the feature byte for byte. Both snapshot variants and the
wire-level tool list are asserted.
2026-10-19 22:59:49 -04:00
ari d3285a994b D: D1 optional peer argument on the eight tools
Peers resolve through PeerRegistry::get, the same entry point REST uses,
so the hop marker, allowlist and error mapping stay in one place. Log
tools keep the local {entries, truncated, note} shape; tail_journal
consumes the peer SSE stream. Tests cover every tool, path encoding,
error mapping and the integration path through the assembled router.
2026-10-19 22:59:49 -04:00
ariandClaude Sonnet 5.5 95fac95389 T: mark merged
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 22:57:56 -04:00
ari 4d7d7defe6 T: a dispatch error raises, so a module-mode session survives a typo 2026-10-19 22:37:08 -04:00
ari e736c12a0e T: log review round 2 (module-mode exit, filter-cache root, handoffs) 2026-10-19 22:37:08 -04:00
ari 5edbd388d1 T: docs: interactive dev-test lives inside devenv shell; module-mode notes
AGENTS.md said the same command works in an interactive shell, which only
holds inside devenv shell or direnv (the script is on PATH there).
docs/consolidator.md now says the filter cache sits at the repo root and that
a failing check raises a catchable error instead of closing the session.
2026-10-19 22:37:08 -04:00
ari b01a409d35 T: anchor the filter cache and its mtime key on the repo root
source-mtime-key globbed src/**/*.rs from the cwd and the cache path was
relative, so completion started in a subdirectory (src/) failed the globs,
keyed the entry "unknown" and wrote <subdir>/target/... under a key that
never goes stale.

The globs (via glob, since ls only expands literal patterns) and the cache
path are anchored on the script's repo root, and an unusable key (unknown or
none) is neither read nor written. check-filter-cache now proves the key and
path are the same from src/ as from the root, and that an unknown key leaves
no file behind.
2026-10-19 22:37:08 -04:00
ari b2a4059080 T: failing checks raise instead of exiting, so module mode keeps the session
run-steps and self-check ended with exit 1. With use dev/dev-test.nu * in a
Nushell config, exit ends the caller's session and cannot be caught, so any
red dev-test unit|all|ci closed the terminal right after the summary.

run-steps and self-check now raise a catchable error; only the script-mode
entry point (main) exits, after printing the reason. check-module-mode guards
that: it rejects exit outside main, rejects (exit ...) interpolated into a
message (a subexpression that ends the process; the cargo-tree message had
one), catches a real failing step in module mode and requires script mode to
still exit non-zero.
2026-10-19 22:37:08 -04:00
ari b476ac2b0c T: rename runner to dev-test 2026-10-19 22:37:08 -04:00
ari 6dade6239d T: review round 1 fix runner argv, filter cache, and the test builtin 2026-10-19 22:37:08 -04:00
ari 40cf1073f4 T: T7 nushell test runner, devenv test script, command lists, docs testing section 2026-10-19 22:37:08 -04:00
ariandClaude Sonnet 5.5 396c382046 C: mark merged
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 22:37:03 -04:00
ari 8b7569363c C: review round 2 proxy query unit rule and shared status classifier
Proxied journal/unit values now use the local unit-name helper instead of a
second, stricter check, so escaped units pass through as text, %5C or %5c.
The peer status table is one function shared with the transport, and the
segment/encoding cases left untested get allowlist and rejection cases.
2026-10-19 22:35:51 -04:00
ari da2e8d7be2 C: record review round 1 responses and handoff for WS-D 2026-10-19 22:35:51 -04:00
ari cfb3a400df C: document proxied unit names, status mapping and peer header rules 2026-10-19 22:35:51 -04:00
ari 7a4d64c051 C: review round 1 proxy fixes
Unit names go through the local route's validation, so escaped and
dash-rooted units work through the proxy; backslashes stay legal only
there. Response preparation (status classification, content-type check,
size/stream bounds) moves into proxy.rs for REST and MCP to share.
x-slinuxm-peer is only set for configured peers, proxied SSE is no-cache,
and the unreachable handler fallbacks are gone.
2026-10-19 22:35:51 -04:00
ari 9be74b9dd8 C: record C1-C4 completion and handoff in the workstream log 2026-10-19 22:35:51 -04:00
ari 767b198ed7 C: C4 REST error mapping through peer_error_to_app with per-row tests 2026-10-19 22:35:51 -04:00
ari 58012018d9 C: C3 x-slinuxm-peer response header on every proxied outcome 2026-10-19 22:35:51 -04:00
ari bab6959a94 C: C2 GET-only pass-through proxy with allowlist, hop guard and query filter 2026-10-19 22:35:51 -04:00
ari bec0ab5736 C: C1 peer status routes 2026-10-19 22:35:51 -04:00
ariandClaude Sonnet 5.5 b1338fdc36 A: mark merged
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 22:32:35 -04:00
ari 0ade90523c A: note the one serve() line the token check needs in the WS-A log 2026-10-19 22:31:29 -04:00
ari 80dec21afd A: use the shared temp-dir fixture in the config tests 2026-10-19 22:31:29 -04:00
ari 47868aa402 A: record the review round 2 responses in the WS-A and WS-B logs 2026-10-19 22:31:29 -04:00
ari 92ad3c8128 A: wire peer check to the real client and probe a real socket in tests
B1/B2 are merged, so `real_transport` builds the `ReqwestTransport` with the
configured limits and deny list instead of bailing. Binary tests now probe a
real loopback server: ok with latency, rejected credential, unreachable peer
and an unknown name, none of which may print the token.
2026-10-19 22:31:29 -04:00
ari e2ff40beae A: test the token-free commands, snapshot print-config and tighten assertions
The peer-less `--print-config` output is now compared against the committed
pre-peers text plus the default `[peers]` block, and a config with a peer
must leave everything before that block byte-identical. New binary tests
cover `--print-config`, `peer list`, `token create|list` with an unreadable
token file, and `serve` refusing to start while naming the peer.
2026-10-19 22:31:29 -04:00
ari de7a47d040 A: cover a directory and a symlink escaping the credentials directory in the loader 2026-10-19 22:31:29 -04:00
ari a02e4f181b A: open peer token files only from serve and peer check
`Config::load` now runs structural checks only (names, URLs, CIDRs, paths,
timeouts) and never touches the host, so `token create|list`, `peer list`,
`peer check` and `--print-config` work where the credential is absent, e.g.
outside the unit. `Config::validate_token_readiness` opens the enabled peers'
files and runs at the top of `serve`; `peer check` checks the probed peer.
Also canonicalise IPv4-mapped IPv6 literals against the deny list and stop
putting the host in the plain-http error while the warning omits it.
2026-10-19 22:31:29 -04:00